Skip to content

Improved efficiency and code reuse with templates and pure functions - #241

Closed
KOLANICH wants to merge 2 commits into
SRombauts:masterfrom
KOLANICH-libs:efficiency
Closed

KOLANICH wants to merge 2 commits into
SRombauts:masterfrom
KOLANICH-libs:efficiency

Conversation

@KOLANICH

Copy link
Copy Markdown
Contributor

No description provided.

@SRombauts SRombauts self-assigned this Dec 24, 2019
@SRombauts

Copy link
Copy Markdown
Owner

Hello, thanks again for this new series of pull requests. Have you seen that they have all failed CI?

@KOLANICH

Copy link
Copy Markdown
Contributor Author

Hello, thanks again for this new series of pull requests.

Not quite new, just splitted the old #182 into multiple PRs.

no template named 'enable_if' in namespace 'std'
error: ‘enable_if’ in namespace ‘std’ does not name a template type

Old versions of C++ should be dropped.

@emmenlau

Copy link
Copy Markdown
Contributor

@KOLANICH I find your PR very valuable but I think it may be easier to digest if split into again smaller parts.

@SRombauts What is your take on the points raised by KOLANICH? Lets take one aspect out, templates. Would you agree that adding stronger use of templates is a good thing? I recently had to fix something about the types in Statement::bind(), and I found what KOLANICH also found, that these methods are quite lengthy code for a thing that would become much shorter and cleaner with templates.

Would you accept a PR that adds stronger use of templates (for better code reuse and shortening of the existing code)?

@SRombauts

Copy link
Copy Markdown
Owner

I am closing this as outdated, but we can reopen the discussion on the basis of smaller scoped PRs

@SRombauts SRombauts closed this Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants